Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689085

Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec

From Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec
Date 2017-07-17 16:20 +0200
Message-ID <u4f2p-69R-1@gated-at.bofh.it> (permalink)
References <u2rAK-1ua-13@gated-at.bofh.it> <u2rAL-1ua-31@gated-at.bofh.it> <u4avM-3bA-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, Jul 17, 2017 at 02:29:29AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170712 08:19]:
> > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> > index 6c78b0b49b81..1615e5acc8fd 100644
> > --- a/sound/soc/codecs/Kconfig
> > +++ b/sound/soc/codecs/Kconfig
> > @@ -401,6 +401,11 @@ config SND_SOC_ALC5632
> >  config SND_SOC_BT_SCO
> >  	tristate "Dummy BT SCO codec driver"
> >  
> > +config SND_SOC_CPCAP
> > +	tristate "Motorola CPCAP codec"
> > +	depends on MFD_CPCAP
> > +	default MFD_CPCAP
> > +
> 
> Should it also have depends on SND_AUDIO_GRAPH_CARD?

The codec does not depend on audio graph card. You can
also use it with (deprecated) simple card or a custom
written one. In case of a custom written one it would
make sense to add a dependency from the custom written
one to SND_SOC_CPCAP. So I think we should not add such
a dependency.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-12 17:30 +0200
  [PATCHv2 4/6] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-12 17:30 +0200
  Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec Takashi Iwai <tiwai@suse.de> - 2017-07-12 17:40 +0200
  Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-17 11:30 +0200
    Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-17 12:20 +0200
      Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-17 12:20 +0200
        Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-17 16:20 +0200
          Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Tony Lindgren <tony@atomide.com> - 2017-07-18 07:50 +0200
            Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-18 11:30 +0200
              Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support Takashi Iwai <tiwai@suse.de> - 2017-07-18 11:40 +0200
  Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec Tony Lindgren <tony@atomide.com> - 2017-07-17 11:30 +0200
    Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-17 16:20 +0200
      Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec Mark Brown <broonie@kernel.org> - 2017-07-17 17:30 +0200

csiph-web