Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689029

[PATCH] PCI: dwc: designware: make dw_pcie_prog_*_atu_unroll() static

Show all headers | View raw

Helper functions dw_pcie_prog_*_atu_unroll don't need to be in global scope,
so make it static.

Cleans up sparse warnings:
- symbol 'dw_pcie_prog_outbound_atu_unroll' was not declared. Should it be static?
- symbol 'dw_pcie_prog_inbound_atu_unroll' was not declared. Should it be static?

Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
Patch made against linux-next tree, tag next-20170714

 drivers/pci/dwc/pcie-designware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c
index 0e03af279259..48d6d0712ea8 100644
--- a/drivers/pci/dwc/pcie-designware.c
+++ b/drivers/pci/dwc/pcie-designware.c
@@ -107,7 +107,7 @@ static void dw_pcie_writel_ob_unroll(struct dw_pcie *pci, u32 index, u32 reg,
 	dw_pcie_writel_dbi(pci, offset + reg, val);
 }

-void dw_pcie_prog_outbound_atu_unroll(struct dw_pcie *pci, int index, int type,
+static void dw_pcie_prog_outbound_atu_unroll(struct dw_pcie *pci, int index, int type,
 				      u64 cpu_addr, u64 pci_addr, u32 size)
 {
 	u32 retries, val;
@@ -200,7 +200,7 @@ static void dw_pcie_writel_ib_unroll(struct dw_pcie *pci, u32 index, u32 reg,
 	dw_pcie_writel_dbi(pci, offset + reg, val);
 }

-int dw_pcie_prog_inbound_atu_unroll(struct dw_pcie *pci, int index, int bar,
+static int dw_pcie_prog_inbound_atu_unroll(struct dw_pcie *pci, int index, int bar,
 				    u64 cpu_addr, enum dw_pcie_as_type as_type)
 {
 	int type;
--
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: dwc: designware: make dw_pcie_prog_*_atu_unroll() static Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-07-17 15:20 +0200
  Re: [PATCH] PCI: dwc: designware: make dw_pcie_prog_*_atu_unroll()  static Joao Pinto <Joao.Pinto@synopsys.com> - 2017-07-17 15:30 +0200
    Re: [PATCH] PCI: dwc: designware: make dw_pcie_prog_*_atu_unroll() static "Jingoo Han" <jingoohan1@gmail.com> - 2017-07-17 21:40 +0200

csiph-web