Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688992

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

Show all headers | View raw

On Sat, Jul 15, 2017 at 01:21:54PM +0530, sunil.m@techveda.org wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
> 
> It is recommended to use managed function devm_kzalloc, which
> simplifies driver cleanup paths and driver code.
> This patch does the following:
> (a) replace kzalloc with devm_kzalloc.
> (b) drop kfree(), because memory allocated with devm_kzalloc() is
> automatically freed on driver detach, otherwise it leads to a double
> free.
> (c) remove unnecessary blank lines.
> 
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
> ---
> Note:
> - Patch was tested and built(ARCH=arm) on next-20170714.
>   No build issues reported, however it was not tested on
>   real hardware.
> ---
>  drivers/staging/ccree/ssi_driver.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c
> index 78709b92..f231ecf 100644
> --- a/drivers/staging/ccree/ssi_driver.c
> +++ b/drivers/staging/ccree/ssi_driver.c
> @@ -224,13 +224,15 @@ static int init_cc_resources(struct platform_device *plat_dev)
>  	struct resource *req_mem_cc_regs = NULL;
>  	void __iomem *cc_base = NULL;
>  	bool irq_registered = false;
> -	struct ssi_drvdata *new_drvdata = kzalloc(sizeof(struct ssi_drvdata), GFP_KERNEL);
> +	struct ssi_drvdata *new_drvdata;
>  	struct device *dev = &plat_dev->dev;
>  	struct device_node *np = dev->of_node;
>  	u32 signature_val;
>  	int rc = 0;
>  
> -	if (unlikely(!new_drvdata)) {
> +	new_drvdata = devm_kzalloc(&plat_dev->dev, sizeof(struct ssi_drvdata),

sizeof(*new_drvdata), right?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] staging: ccree: Employ devm_* functions, remove redundant code sunil.m@techveda.org - 2017-07-15 10:00 +0200
  [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc sunil.m@techveda.org - 2017-07-15 10:00 +0200
    Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc Greg KH <gregkh@linuxfoundation.org> - 2017-07-17 14:40 +0200
      Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc Suniel Mahesh <sunil.m@techveda.org> - 2017-07-18 06:40 +0200
  [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap sunil.m@techveda.org - 2017-07-15 10:00 +0200
  [PATCH 3/3] staging: ccree: Use platform_get_irq and devm_request_irq sunil.m@techveda.org - 2017-07-15 10:00 +0200

csiph-web