Re: [PATCH] backlight: pwm_bl: make of_device_ids const

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] backlight: pwm_bl: make of_device_ids const
Date	2017-07-17 14:30 +0200
Message-ID	<u4djX-4Wt-5@gated-at.bofh.it> (permalink)
References	<tUmeS-5LQ-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 20 Jun 2017, Arvind Yadav wrote:

> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/video/backlight/pwm_bl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 002f1ce..9bd1768 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
>  	return 0;
>  }
>  
> -static struct of_device_id pwm_backlight_of_match[] = {
> +static const struct of_device_id pwm_backlight_of_match[] = {
>  	{ .compatible = "pwm-backlight" },
>  	{ }
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] backlight: pwm_bl: make of_device_ids const Lee Jones <lee.jones@linaro.org> - 2017-07-17 14:30 +0200

csiph-web