Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code
Date	Mon, 17 Jul 2017 15:10:03 +0200
Message-ID	<u4dWH-5qj-41@gated-at.bofh.it> (permalink)
References	<u38cH-3uL-15@gated-at.bofh.it> <u38cH-3uL-27@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6ztmVc2zUlJHgWmsZB0NkFaI6DvPlbECDrKvTHOQtm0=; b=AKbiGOcS/kzxSO3fnjZxC4NL4UJ8I68YH1n3MjHX/vl6oiU5OygMEYbyZl0uaWSTAe LrKs/wQz7sHQN/TZyiqdzr9vMuvBDKJpjsMBzAT2eJ+axOanog+PUEDVqb4lRVWWScQW 4wFFb//Lp5IF2BBJ09fXsKBhGnh63DYkpuP8A=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6ztmVc2zUlJHgWmsZB0NkFaI6DvPlbECDrKvTHOQtm0=; b=QWI3KD7kIVKiVkxR+or7ar524e3pFoXUyYOj6Wlkr355a+O0Romkcan+fuifZbp06Y 4x6UQbdYINDFE8MdueudZihHBIplVJtc31BBy3+7ESj7AAacfqeGHnQdZTJ4hraPFll+ 0Lpz3YU5NK9gs2EHNQL96DUbAfL2ADbT/y0PUX5GBBp+UU10NUxy/0CQAeXrs3zww1/0 fEaM31RWH9wBsDoNNEGDUYN7wMOphBR7UyVlJjMibLyNRuSEM0ZpSH8Egq8C72TKz0kD 7dQGpVFjCqh05CusKrKLq0TNw9nmg3EATSagCTOLbY0qnJ23EJ3TdZyom6plSsiuUxrX 60gw==
X-Gm-Message-State	AIVw1120Ypgz0dD/3qgEGvrN3FKhQz29SiMs8KT5MhPhUCU0uX/GK0oK 5BHEYsjzHFNfWT4yyDDPRn4HoGkGa94sNkM=
X-Received	by 10.233.232.212 with SMTP id a203mr24374488qkg.261.1500296935097; Mon, 17 Jul 2017 06:08:55 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Tony Lindgren <tony@atomide.com>, Russell King <linux@armlinux.org.uk>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-omap <linux-omap@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Kishon <kishon@ti.com>, Ravikumar Kattekola <rk@ti.com>, Sekhar Nori <nsekhar@ti.com>, Linus Walleij <linus.walleij@linaro.org>, Heiner Kallweit <hkallweit1@gmail.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>
X-Original-Date	Mon, 17 Jul 2017 15:08:54 +0200
X-Original-Message-ID	<CAPDyKFpwb3T4PhQSyUwWDwpEnOwVDxLeK7hAMS0Q4P3tzPXXrQ@mail.gmail.com>
X-Original-References	<1500036404-5556-1-git-send-email-faiz_abbas@ti.com> <1500036404-5556-2-git-send-email-faiz_abbas@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1689021

Show key headers only | View raw

On 14 July 2017 at 14:46, Faiz Abbas <faiz_abbas@ti.com> wrote:
> Most platforms using OMAP hsmmc driver have switched to device tree
> for passing platform data to omap_hsmmc.c driver.
>
> The hsmmc.c file in mach-omap2 exists only to support pandora board
> which uses wl1251 driver in legacy platform data mode.
>
> Hence, remove the dead code not used by the pandora board.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

I just got an ack from Tony to pick this up. So I did that (including
the mmc change in patch 2) and intend to send this for 4.13 rcs, via
my fixes branch in my mmc tree.

However the below comment for testing puzzles me. Either it's dead
code or not, so then what is there to test? :-)

Anyway, it's available on my fixes and next branch, so let's see if
zero build reports some issues.

> ---
> This is only compile tested. Someone with a pandora board should help
> test this for functionality.
>
>  arch/arm/mach-omap2/hsmmc.c | 239 +-------------------------------------------
>  arch/arm/mach-omap2/hsmmc.h |   9 --
>  2 files changed, 2 insertions(+), 246 deletions(-)

[...]

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code Faiz Abbas <faiz_abbas@ti.com> - 2017-07-14 14:50 +0200
  Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-17 15:10 +0200

csiph-web