Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1688930
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/9] mfd: Drop unnecessary static |
| Date | 2017-07-17 13:10 +0200 |
| Message-ID | <u4c4z-4fj-7@gated-at.bofh.it> (permalink) |
| References | <tDvHz-8tt-5@gated-at.bofh.it> <tDvHB-8tt-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 04 May 2017, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any use, on every possible execution path through the function. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > // </smpl> > > The change increases the code size but decreases the size of the bss segment. > > before: > text data bss dec hex filename > 3369 272 300 3941 f65 drivers/mfd/twl4030-irq.o > > after: > text data bss dec hex filename > 3401 272 28 3701 e75 drivers/mfd/twl4030-irq.o > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/mfd/twl4030-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 5/9] mfd: Drop unnecessary static Lee Jones <lee.jones@linaro.org> - 2017-07-17 13:10 +0200
csiph-web