Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1688878

[PATCH] perf probe: Fix build failure for get_target_map()

From Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject [PATCH] perf probe: Fix build failure for get_target_map()
Date 2017-07-17 12:40 +0200
Message-ID <u4bBy-3PU-51@gated-at.bofh.it> (permalink)
References <u045z-5Wp-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Commit 801bc8193463 ("perf probe: Allow placing uprobes in
alternate namespaces.") is causing a build failure on powerpc:

  error: incompatible type for argument 2 of 'get_target_map'
  map = get_target_map(pev->target, pev->uprobes);
                                    ^~~

Fix it by changing parameters of get_target_map().

Fixes: 801bc8193463 ("perf probe: Allow placing uprobes in alternate namespaces.")
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
---
 tools/perf/arch/powerpc/util/sym-handling.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c
index bf9a259..9c4e23d 100644
--- a/tools/perf/arch/powerpc/util/sym-handling.c
+++ b/tools/perf/arch/powerpc/util/sym-handling.c
@@ -126,7 +126,7 @@ void arch__post_process_probe_trace_events(struct perf_probe_event *pev,
 	struct rb_node *tmp;
 	int i = 0;
 
-	map = get_target_map(pev->target, pev->uprobes);
+	map = get_target_map(pev->target, pev->nsi, pev->uprobes);
 	if (!map || map__load(map) < 0)
 		return;
 
-- 
2.1.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH tip/perf/core 6/7] perf documentation: updates for  target-ns. Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-03 20:50 +0200
  Re: [PATCH tip/perf/core 6/7] perf documentation: updates for  target-ns. Krister Johansen <kjlx@templeofstupid.com> - 2017-07-05 22:50 +0200
    [PATCH v2 tip/perf/core 3/6] perf probe: allow placing uprobes in alternate namespaces. Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
      [PATCH] perf probe: Fix build failure for get_target_map() Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-07-17 12:40 +0200
        Re: [PATCH] perf probe: Fix build failure for get_target_map() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-17 15:20 +0200
          Re: [PATCH] perf probe: Fix build failure for get_target_map() Michael Ellerman <mpe@ellerman.id.au> - 2017-07-18 11:20 +0200
    [PATCH v2 tip/perf/core 6/6] perf buildid-cache: cache debuginfo Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
    [PATCH v2 tip/perf/core 5/6] perf top: support lookup of symbols in other mount namespaces. Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
    [PATCH v2 tip/perf/core 4/6] perf buildid-cache: support binary objects from other namespaces Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
    [PATCH v2 tip/perf/core 0/6] namespace tracing improvements Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
      [PATCH v2 tip/perf/core 2/6] perf maps: lookup maps in both intitial mountns and inner mountns. Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
      [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in different mount namespace Krister Johansen <kjlx@templeofstupid.com> - 2017-07-06 03:50 +0200
        Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-06 21:50 +0200
          Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Krister Johansen <kjlx@templeofstupid.com> - 2017-07-07 21:40 +0200
            Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Thomas-Mich Richter <tmricht@linux.vnet.ibm.com> - 2017-07-10 08:20 +0200
              Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Krister Johansen <kjlx@templeofstupid.com> - 2017-07-11 00:50 +0200
                Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-11 01:00 +0200
                Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Krister Johansen <kjlx@templeofstupid.com> - 2017-07-11 01:40 +0200
                Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-11 15:00 +0200
                Re: [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in  different mount namespace Krister Johansen <kjlx@templeofstupid.com> - 2017-07-11 19:20 +0200

csiph-web