Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1688812
| From | Joao Pinto <Joao.Pinto@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] PCI: dwc: designware: test PCIE_ATU_ENABLE bit to check enabled or not |
| Date | 2017-07-17 11:30 +0200 |
| Message-ID | <u4avM-3bA-5@gated-at.bofh.it> (permalink) |
| References | <u2JR0-4v9-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
Às 11:35 AM de 7/13/2017, Jisheng Zhang escreveu:
> The ATU CTRL2 register is 32 bit, besides the enable bit, other bits
> may also be set. To check whether the ATU is enabled or not, we should
> test the enable it.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/pci/dwc/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c
> index 0e03af279259..6bf0b409050a 100644
> --- a/drivers/pci/dwc/pcie-designware.c
> +++ b/drivers/pci/dwc/pcie-designware.c
> @@ -177,7 +177,7 @@ void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type,
> */
> for (retries = 0; retries < LINK_WAIT_MAX_IATU_RETRIES; retries++) {
> val = dw_pcie_readl_dbi(pci, PCIE_ATU_CR2);
> - if (val == PCIE_ATU_ENABLE)
> + if (val & PCIE_ATU_ENABLE)
> return;
>
> usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
>
Make sense, turn it more accurate. Thanks!
Acked-by: Joao Pinto <jpinto@synopsys.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] PCI: dwc: designware: test PCIE_ATU_ENABLE bit to check enabled or not Jisheng Zhang <jszhang@marvell.com> - 2017-07-13 12:50 +0200
Re: [PATCH] PCI: dwc: designware: test PCIE_ATU_ENABLE bit to check enabled or not Joao Pinto <Joao.Pinto@synopsys.com> - 2017-07-17 11:30 +0200
Re: [PATCH] PCI: dwc: designware: test PCIE_ATU_ENABLE bit to check enabled or not "Jingoo Han" <jingoohan1@gmail.com> - 2017-07-17 21:40 +0200
csiph-web