Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691898

Re: [PATCH] ARM: Convert to using %pOF instead of full_name

Show all headers | View raw

On Wed, Jul 19, 2017 at 1:22 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>
> Oh nice. If the commit adding %pOF is already set in stone, i'd suggest
> to mention the commit id here in the commit log.

It is in 4.13, but I'm not really eager to update all 60 patches and
I'd prefer consistency in the commit msg as quite a few have already
been applied.

>> of the full path string for each node.

[...]

>> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
>>                */
>>               cell = of_get_property(cpu, "reg", &prop_bytes);
>>               if (!cell || prop_bytes < sizeof(*cell)) {
>> -                     pr_debug(" * %s missing reg property\n",
>> -                                  cpu->full_name);
>> +                     pr_debug(" * %pOF missing reg property\n",
>> +                                  cpu);
>
> You could join lines here and in the next hunk. And there are two more
> further down.

Okay. I did that generally, but missed a few.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: Convert to using %pOF instead of full_name Rob Herring <robh@kernel.org> - 2017-07-19 00:10 +0200
  Re: [PATCH] ARM: Convert to using %pOF instead of full_name Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-19 08:00 +0200
  Re: [PATCH] ARM: Convert to using %pOF instead of full_name Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-19 08:30 +0200
    Re: [PATCH] ARM: Convert to using %pOF instead of full_name Rob Herring <robh@kernel.org> - 2017-07-19 17:40 +0200
  Re: [PATCH] ARM: Convert to using %pOF instead of full_name Heiko Stuebner <heiko@sntech.de> - 2017-07-19 10:10 +0200
  Re: [PATCH] ARM: Convert to using %pOF instead of full_name Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-19 11:10 +0200
  Re: [PATCH] ARM: Convert to using %pOF instead of full_name Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-07-19 13:50 +0200
  Re: [PATCH] ARM: Convert to using %pOF instead of full_name Paul Walmsley <paul@pwsan.com> - 2017-07-27 17:20 +0200

csiph-web