Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691888

Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver

Show all headers | View raw

Hi Philipp,

On Wed, 2017-07-19 at 17:07 +0200, Philipp Zabel wrote:
> On Tue, 2017-07-18 at 20:25 +0300, Eugeniy Paltsev wrote:
> > The HSDK v1 periphery IPs can be reset by accessing some registers
> > from the CGU block.
> > 
> > The list of available reset lines is documented in the DT bindings.
> > 
> > [snip]
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -34,6 +34,12 @@ config RESET_BERLIN
> >  	help
> >  	  This enables the reset controller driver for Marvell
> > Berlin SoCs.
> >  
> > +config RESET_HSDK_V1
> > +	bool "HSDK v1 Reset Driver"
> > +	default n
> 
> I suppose there will be a SOC_HSDK_V1 or similar in the future so
> that
> we can hide this option and enable it by default like the other reset
> drivers?
Actually we don't have (and don't planning to add) such SOC/board-
specific kconfig option, so I am wondering if it is OK to just left
this option not hidden?

> > [snip]
> > +
> > +#define CGU_ARC_RST_CTRL		0x0
> > +#define CGU_SYS_RST_CTRL		0x20
> > +#define CGU_DDR_RST_CTRL		0x40
> > +#define CGU_TUN_RST_CTRL		0x60
> 
> The ARC, DDR, and TUN reset control registers are never used.
Ok, I'll remove unused register defines.

> > [snip]
> 
> regards
> Philipp
> 
Thanks.
-- 
 Eugeniy Paltsev

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARC: reset: introduce HSDKv1 reset driver Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-07-18 19:30 +0200
  Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-19 17:10 +0200
    Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-07-19 17:40 +0200
      Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-19 17:50 +0200

csiph-web