Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691836

Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage
Date 2017-07-19 17:20 +0200
Message-ID <u4YVA-1TU-7@gated-at.bofh.it> (permalink)
References <u4WK7-fH-53@gated-at.bofh.it> <u4Ysy-1t8-13@gated-at.bofh.it> <u4YCe-1x4-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 19, 2017 at 04:51:02PM +0200, Juergen Gross wrote:
> On 19/07/17 16:43, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > It's better to be explicit and use the DRIVER_ATTR_RW() and
> > DRIVER_ATTR_RO() macros when defining a driver's sysfs file.
> > 
> > Bonus is this fixes up a checkpatch.pl warning.
> > 
> > This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> > 
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: Juergen Gross <jgross@suse.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>
> 
> I'll take this through the Xen tree, unless you want to use your tree.

If I can take it through mine, then I could drop DRIVER_ATTR() from the
whole tree for the next kernel release, which would be ideal.

But if you want to take it, that's fine, I can wait another release, no
rush.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen: xen-pciback: remove DRIVER_ATTR() usage Greg KH <gregkh@linuxfoundation.org> - 2017-07-19 15:00 +0200
  Re: [PATCH] xen: xen-pciback: remove DRIVER_ATTR() usage Juergen Gross <jgross@suse.com> - 2017-07-19 15:20 +0200
    Re: [PATCH] xen: xen-pciback: remove DRIVER_ATTR() usage Greg KH <gregkh@linuxfoundation.org> - 2017-07-19 16:30 +0200
  [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage Greg KH <gregkh@linuxfoundation.org> - 2017-07-19 16:50 +0200
    Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage Juergen Gross <jgross@suse.com> - 2017-07-19 17:00 +0200
      Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage Greg KH <gregkh@linuxfoundation.org> - 2017-07-19 17:20 +0200
        Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage Juergen Gross <jgross@suse.com> - 2017-07-19 19:30 +0200

csiph-web