Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1691086
| From | Chen Lin <chen.lin5@zte.com.cn> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu |
| Date | 2017-07-19 10:00 +0200 |
| Message-ID | <u4S3M-5v4-23@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must be the same with the byterorder defined in struct w1_reg_num. The rn read from 'rv = w1_read_block(dev, (u8 *)&rn, 8)' is a byte serial and not cpu endian relative, it need to change to cpu endian before passed to w1_slave_found. Signed-off-by: Chen Lin <chen.lin5@zte.com.cn> Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn> --- Forgot the description in v1. --- drivers/w1/w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 95ea7e6..c531545 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -979,7 +979,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb mutex_unlock(&dev->bus_mutex); if (rv == 8 && rn) - cb(dev, rn); + cb(dev, le64_to_cpu(rn)); break; } -- 1.8.3.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu Chen Lin <chen.lin5@zte.com.cn> - 2017-07-19 10:00 +0200
csiph-web