Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1691048
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 6/8] s390: raw3270: constify attribute_group structures. |
| Date | 2017-07-19 09:20 +0200 |
| Message-ID | <u4Rr3-5eb-9@gated-at.bofh.it> (permalink) |
| References | <u4Rr3-5eb-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
8069 816 16 8901 22c5 drivers/s390/char/raw3270.o
File size After adding 'const':
text data bss dec hex filename
8133 752 16 8901 22c5 drivers/s390/char/raw3270.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/s390/char/raw3270.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index 710f229..5d4f053 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -1082,7 +1082,7 @@ struct raw3270_view *
NULL,
};
-static struct attribute_group raw3270_attr_group = {
+static const struct attribute_group raw3270_attr_group = {
.attrs = raw3270_attrs,
};
--
1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 6/8] s390: raw3270: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-19 09:20 +0200
csiph-web