Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI
Date	2017-07-19 09:00 +0200
Message-ID	<u4R7J-4R3-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <u4zku-1WQ-3@gated-at.bofh.it> <u4LYl-1wx-7@gated-at.bofh.it> <u4P5T-3vt-1@gated-at.bofh.it> <u4QEG-4FE-21@gated-at.bofh.it> <u4QOm-4Jj-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jul 19, 2017 at 09:33:49AM +0300, Baruch Siach wrote:
> Hi Yong,
> 
> On Wed, Jul 19, 2017 at 02:21:20PM +0800, Yong wrote:
> > On Wed, 19 Jul 2017 07:49:23 +0300
> > Baruch Siach <baruch@tkos.co.il> wrote:
> > > On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote:
> > > > I am waiting for more comments for the sunxi-csi.h. It's pleasure if
> > > > you have any suggestions about it.
> > > 
> > > You mean sunxi_csi.h, right?
> > 
> > Yes. My spelling mistake.
> > 
> > > Why do you need the sunxi_csi_ops indirection? Do you expect to add 
> > > alternative implementations of these ops at some point?
> > 
> > I want to seperate the sunxi_video.c and sunxi_csi_v3s.c. 
> > sunxi_csi_v3s.c is Soc specific. Maybe there will be sunxi_csi_r40.c
> > in the futrue. But the sunxi_video.c and sunxi_csi.c are common.
> 
> I'd say it is a premature optimization. The file separation is fine, IMO, but 
> the added csi_ops indirection makes the code less readable. Someone with 
> access to R40 hardware with CSI setup would be a better position to abstract 
> the platform specific code.

I agree

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Baruch Siach <baruch@tkos.co.il> - 2017-07-18 14:00 +0200
  Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Yong <yong.deng@magewell.com> - 2017-07-19 03:30 +0200
    Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Baruch Siach <baruch@tkos.co.il> - 2017-07-19 06:50 +0200
      Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Yong <yong.deng@magewell.com> - 2017-07-19 08:30 +0200
        Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Baruch Siach <baruch@tkos.co.il> - 2017-07-19 08:40 +0200
          Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-19 09:00 +0200
            Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for  Allwinner CSI Yong <yong.deng@magewell.com> - 2017-07-19 09:10 +0200

csiph-web