Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690993

Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Show all headers | View raw

Logan Gunthorpe <logang@deltatee.com> writes:

> Subsequent patches in this series makes use of the readq and writeq
> defines in iomap.h. However, as is, they get missed on the powerpc
> platform seeing the include comes before the define. This patch
> moves the include down to fix this.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Suresh Warrier <warrier@linux.vnet.ibm.com>
> Cc: "Oliver O'Halloran" <oohall@gmail.com>
> ---
>  arch/powerpc/include/asm/io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Seems fair enough, have you tested it at all?

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] make io{read|write}64 globally usable Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 19:00 +0200
  [PATCH v4 2/5] iomap: introduce io{read|write}64_{lo_hi|hi_lo} Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 19:00 +0200
  [PATCH v4 3/5] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 19:00 +0200
  [PATCH v4 4/5] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 19:00 +0200
    RE: [PATCH v4 4/5] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-07-18 20:00 +0200
  [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 19:00 +0200
    Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Michael Ellerman <mpe@ellerman.id.au> - 2017-07-19 08:00 +0200
      Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can  use readq/writeq defs Logan Gunthorpe <logang@deltatee.com> - 2017-07-19 18:10 +0200
        Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can  use readq/writeq defs Horia Geantă <horia.geanta@nxp.com> - 2017-07-20 12:30 +0200
          Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can  use readq/writeq defs Horia Geantă <horia.geanta@nxp.com> - 2017-07-20 14:40 +0200
            Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can  use readq/writeq defs Logan Gunthorpe <logang@deltatee.com> - 2017-07-20 17:50 +0200
        Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Michael Ellerman <mpe@ellerman.id.au> - 2017-07-20 13:20 +0200

csiph-web