Re: [PATCH] livepatch: add (un)patch hooks

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] livepatch: add (un)patch hooks
Date	Wed, 19 Jul 2017 04:10:03 +0200
Message-ID	<u4MB5-20G-1@gated-at.bofh.it> (permalink)
References	<u2qEF-Q6-5@gated-at.bofh.it> <u2qEF-Q6-19@gated-at.bofh.it> <u2XTY-4Tk-5@gated-at.bofh.it> <u4yHM-1HH-25@gated-at.bofh.it>
X-Original-To	Miroslav Benes <mbenes@suse.cz>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 795C47C83A
Authentication-Results	ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com
Dkim-Filter	OpenDKIM Filter v2.11.0 mx1.redhat.com 795C47C83A
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.6.0.1 (2016-04-01)
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.12
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 19 Jul 2017 02:09:00 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Joe Lawrence <joe.lawrence@redhat.com>, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>, Petr Mladek <pmladek@suse.com>, Chris J Arges <chris.j.arges@canonical.com>
X-Original-Date	Tue, 18 Jul 2017 21:08:57 -0500
X-Original-Message-ID	<20170719020857.6gvkw4di2vjmk2ii@treble>
X-Original-References	<1499868600-10176-1-git-send-email-joe.lawrence@redhat.com> <1499868600-10176-2-git-send-email-joe.lawrence@redhat.com> <20170714014640.nhoowbrleu6kdka2@treble> <alpine.LSU.2.20.1707181310550.24826@pobox.suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1690908

Show key headers only | View raw

On Tue, Jul 18, 2017 at 01:15:16PM +0200, Miroslav Benes wrote:
> On Thu, 13 Jul 2017, Josh Poimboeuf wrote:
> 
> > On Wed, Jul 12, 2017 at 10:10:00AM -0400, Joe Lawrence wrote:
> > > When the livepatch core executes klp_(un)patch_object, call out to a
> > > livepatch-module specified array of callback hooks.  These hooks provide
> > > a notification mechanism for livepatch modules when klp_objects are
> > > (un)patching. This may be most interesting when another kernel module
> > > is a klp_object target and the livepatch module needs to execute code
> > > after the target is loaded, but before its module_init code is run.
> > 
> > And it's also useful for vmlinux.  Patch module load/unload is separate
> > from enable/disable, so the module init/exit functions can't be used for
> > patch-specific changes (e.g., global data changes).
> 
> I admit that I don't understand this, which is probably the reason for my 
> question. Why do we need it when we have module notifiers and module 
> init/exit functions in the kernel? Petr described different possible 
> scenarios and they can be solved either in init/exit function of a patch 
> module or in a module notifier which the patch module can register.
> 
> If there is a difference, it should be mentioned in the documentation and 
> in the changelog.

Some differences:

- The patch module init/exit code doesn't run when disabling and
  re-enabling a patch.

- The module notifier can't stop the to-be-patched module from loading.

-- 
Josh

Thread

Re: [PATCH] livepatch: add (un)patch hooks Miroslav Benes <mbenes@suse.cz> - 2017-07-18 13:20 +0200
  Re: [PATCH] livepatch: add (un)patch hooks Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-19 04:10 +0200
    Re: [PATCH] livepatch: add (un)patch hooks Petr Mladek <pmladek@suse.com> - 2017-07-19 17:40 +0200
    Re: [PATCH] livepatch: add (un)patch hooks Miroslav Benes <mbenes@suse.cz> - 2017-07-19 21:20 +0200

csiph-web