Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690870

[PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From David Carrillo-Cisneros <davidcc@google.com>
Newsgroups linux.kernel
Subject [PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled
Date Wed, 19 Jul 2017 03:20:02 +0200
Message-ID <u4LOG-1ts-15@gated-at.bofh.it> (permalink)
References <u4LOF-1ts-3@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SaWwEHXqFVCWNl+xHds+CNEaMO5Whr5sYPD8YOORCMw=; b=Zkg8OZsCO9ToZFcWE4LT5tD5aU1/7nGK0iU1YTgBosf/sRUXcAGF/A4ktM2jjMeOKY kvsBhx+smlNxlyjILh/CAG2zIY1EUMyNV9iB0kU1ufFN2xjDWoMDXIRvS84+cFjdOpXY R1w+nGGKsZggMqZoX9+xhsppfuBei+TUqqoIXFYuZMzkfwEqZS2W2Eo6ViDNSje3EFEw HerfWkhERMF8HR6nroEt1OqvW4bDkUl+o7K5dlK9TrQxnThTFWFLF4yTDXm7YkknUh5h GpbRp9etEXAG/+UZrfTI9VB/F3G/sqy42sFs9KJsYCabdccFhxUf2SdIV7t1UcRfalEn DdRg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SaWwEHXqFVCWNl+xHds+CNEaMO5Whr5sYPD8YOORCMw=; b=t0Ww1oqp0ATFY71BSvCtHuxqqvZxIXyuibchHQLehEwO5Bsrlhkvrs/U5KRW7tAFX0 kAkCAU7nyyGydNKJsrrZVc8XhVvaR5olx6JxeSdBsK2ZHU8XqXwlElbv1F84SS1uA8r6 dZDLvL2BIIEOvyS9941zcaKv3zC3H0KEkH/pjmwrd5YgaH7Jfz1PL2Ic1wlndGAfCzF4 W6m08YWgDvjnCkl+w8nUfnSIYEdJawz54bDdAGul/o2TmjFsoF1Z6iWiWCjzA2jfPr6G eMcaP7jk/vjZmfP5P0o0p62dW4/cweitVbZqF4Ql2XMuPe6rQaDDjDSWWoTacmooG+Nt iieg==
X-Gm-Message-State AIVw110d2zdggRM7dXi+kyeVtyOt8Ms9ogmxgLML42Ic4Uv5ubH+tGlZ Nt857TsbHWvuygVzQFYfuQ==
X-Received by 10.84.136.36 with SMTP id 33mr410549plk.123.1500427145272; Tue, 18 Jul 2017 18:19:05 -0700 (PDT)
X-Mailer git-send-email 2.14.0.rc0.284.gd933b75aa4-goog
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 38
Organization linux.* mail to news gateway
X-Original-Cc Kees Kook <keescook@chromium.org>, Sudeep Holla <Sudeep.Holla@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Wang Nan <wangnan0@huawei.com>, Elena Reshetova <elena.reshetova@intel.com>, Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Sudeep Holla <sudeep.holla@arm.com>
X-Original-Date Tue, 18 Jul 2017 18:18:39 -0700
X-Original-Message-ID <20170719011839.99399-5-davidcc@google.com>
X-Original-References <20170719011839.99399-1-davidcc@google.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1690870

Show key headers only | View raw

From: Sudeep Holla <Sudeep.Holla@arm.com>

When libelf is disabled in the configuration, we get the following
linker error:
  LINK     libperf-jvmti.so
  ld: cannot find -lelf
  Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed

Jiri pointed out that both librt and libelf are not really required. So
this patch fixes the linker error by getting rid of unwanted libraries
in the linker stage.

Fixes: 209045adc2bb ("perf tools: add JVMTI agent library")
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 100a6c1670c8..d66f90e6be5c 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -518,7 +518,7 @@ $(LIBJVMTI_IN): FORCE
 	$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti
 
 $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
-	$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
+	$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $<
 endif
 
 $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
-- 
2.13.2.932.g7449e964c-goog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Resubmitted forgotten patches David Carrillo-Cisneros <davidcc@google.com> - 2017-07-19 03:20 +0200
  [PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled David Carrillo-Cisneros <davidcc@google.com> - 2017-07-19 03:20 +0200
    [tip:perf/core] perf jvmti: Fix linker error when libelf config is  disabled tip-bot for Sudeep Holla <tipbot@zytor.com> - 2017-07-26 19:30 +0200
  [PATCH 1/4] perf tool cgroup: Initialize cgroup refcnt with refcount_set David Carrillo-Cisneros <davidcc@google.com> - 2017-07-19 03:20 +0200
    Re: [PATCH 1/4] perf tool cgroup: Initialize cgroup refcnt with  refcount_set Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-21 19:00 +0200
  [PATCH 2/4] perf tools: Add EXCLUDE_EXTLIBS and EXTRA_PERFLIBS to makefile David Carrillo-Cisneros <davidcc@google.com> - 2017-07-19 03:20 +0200
    [tip:perf/core] perf tools: Add EXCLUDE_EXTLIBS and EXTRA_PERFLIBS  to makefile tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-07-26 19:30 +0200
  Re: [PATCH 0/4] Resubmitted forgotten patches Jiri Olsa <jolsa@redhat.com> - 2017-07-19 10:50 +0200
  Re: [PATCH 0/4] Resubmitted forgotten patches Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-21 19:10 +0200

csiph-web