[PATCH 3/4] perf annotate: Process tracing data in pipe mode

From	David Carrillo-Cisneros <davidcc@google.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/4] perf annotate: Process tracing data in pipe mode
Date	2017-07-19 03:20 +0200
Message-ID	<u4LOF-1ts-1@gated-at.bofh.it> (permalink)
References	<u4LOF-1ts-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

perf annotate was missing the handler for tracing data records.

Prior to this patch we obtained "unhandled" records when piping
trace events to perf annotate (using -D option to show the
dump_printf messages in process_event_synth_tracing_data_stub):

  $ perf record -o - -e block:bio_free sleep 2 | perf annotate -D --stdio
  ...
  0x78 [0xc]: PERF_RECORD_TRACING_DATA: unhandled!
  ...

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/perf/builtin-annotate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 5205408e795b..ffe28002dc4f 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -397,6 +397,7 @@ int cmd_annotate(int argc, const char **argv)
 			.namespaces = perf_event__process_namespaces,
 			.attr	= perf_event__process_attr,
 			.build_id = perf_event__process_build_id,
+			.tracing_data   = perf_event__process_tracing_data,
 			.feature	= perf_event__process_feature,
 			.ordered_events = true,
 			.ordering_requires_timestamps = true,
-- 
2.13.2.932.g7449e964c-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] perf annotate: Process tracing data in pipe mode David Carrillo-Cisneros <davidcc@google.com> - 2017-07-19 03:20 +0200
  [tip:perf/core] perf annotate: Process tracing data in pipe mode tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-07-26 19:30 +0200

csiph-web