Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1690672

RE: [PATCH] workqueue: doc change for ST behavior on NUMA systems

From Alexei Potashnik <alexei@purestorage.com>
Newsgroups linux.kernel
Subject RE: [PATCH] workqueue: doc change for ST behavior on NUMA systems
Date 2017-07-18 23:40 +0200
Message-ID <u4InM-7Gm-17@gated-at.bofh.it> (permalink)
References <u4Fgd-5OA-3@gated-at.bofh.it> <u4Gci-6nx-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


target has a bug in TMR handling.

        dev->tmr_wq = alloc_workqueue("tmr-%s", WQ_MEM_RECLAIM |
WQ_UNBOUND, 1,
                                      dev->transport->name);

LUN_RESET can race with TASK_ABORT in different sessions.
Will send a patch to target list.

-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Tuesday, July 18, 2017 12:18 PM
To: Alexei Potashnik <alexei@purestorage.com>
Cc: tj@kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: doc change for ST behavior on NUMA systems

On Tue, Jul 18, 2017 at 11:12:53AM -0700, Alexei Potashnik wrote:
> NUMA rework of workqueue made the combination of max_active of 1 and
> WQ_UNBOUND insufficient to guarantee ST behavior system wide.
>
> alloc_ordered_queue should now be used instead.

Eww.  And how many existing users might be broken by that?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] workqueue: doc change for ST behavior on NUMA systems Alexei Potashnik <alexei@purestorage.com> - 2017-07-18 20:20 +0200
  Re: [PATCH] workqueue: doc change for ST behavior on NUMA systems Tejun Heo <tj@kernel.org> - 2017-07-18 20:40 +0200
  Re: [PATCH] workqueue: doc change for ST behavior on NUMA systems Christoph Hellwig <hch@infradead.org> - 2017-07-18 21:20 +0200
    Re: [PATCH] workqueue: doc change for ST behavior on NUMA systems Tejun Heo <tj@kernel.org> - 2017-07-18 21:40 +0200
    RE: [PATCH] workqueue: doc change for ST behavior on NUMA systems Alexei Potashnik <alexei@purestorage.com> - 2017-07-18 23:40 +0200
    RE: [PATCH] workqueue: doc change for ST behavior on NUMA systems Alexei Potashnik <alexei@purestorage.com> - 2017-07-19 00:30 +0200
    [PATCH wq/for-4.13-fixes] workqueue: restore  WQ_UNBOUND/max_active==1 to be ordered Tejun Heo <tj@kernel.org> - 2017-07-19 00:50 +0200
      Re: [PATCH wq/for-4.13-fixes] workqueue: restore  WQ_UNBOUND/max_active==1 to be ordered Tejun Heo <tj@kernel.org> - 2017-07-19 17:30 +0200

csiph-web