Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690556

Re: [PATCH] kbuild: modpost: Warn about references from rodata to __init text

Show all headers | View raw

2017-07-01 7:58 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
> If we have a structure that's marked const it will be placed
> into the .rodata section but it could reference an init section
> function. Include the read only data section in the check we have
> for read/write data sections referencing init sections so we can
> find this class of problems. This exposes quite a few places
> where const marked structures are referencing __init functions and
> __init data that we were previously ignoring.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> Making this change leads to quite a few other errors even on the
> multi_v7_defconfig for ARM[1]. I still need to do a build of the
> allmodconfig to see how many other errors there, but it seems to
> be quite a few. I suppose those will need to be fixed before we can
> merge this?
>
> [1] https://www.irccloud.com/pastebin/zzqfWGQY/

Applied to linux-kbuild/misc.  Thanks!

Now people will notice the warnings in linux-next,
and will start fixing drivers.
We still have plenty of time until the next merge windows.  :-)

-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] kbuild: modpost: Warn about references from rodata to  __init text Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-18 20:40 +0200

csiph-web