Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690513
| From | Waiman Long <longman@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support |
| Date | 2017-07-18 19:30 +0200 |
| Message-ID | <u4EtQ-5hK-25@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <u43DY-7fA-1@gated-at.bofh.it> <u4f2q-69R-41@gated-at.bofh.it> <u4lhv-1tE-9@gated-at.bofh.it> <u4BPj-3zB-9@gated-at.bofh.it> <u4Eka-5e8-15@gated-at.bofh.it> |
| Organization | Red Hat |
On 07/18/2017 01:10 PM, Tejun Heo wrote: > Hello, Waiman. > > On Tue, Jul 18, 2017 at 10:37:41AM -0400, Waiman Long wrote: >> Thinking about it some more. There is a place for invalid domain. It is >> not the child of a threaded cgroup. It is the siblings of a threaded >> cgroup whose parent is not root. >> >> Root - A (domain) - B (domain) >> \ C (domain) >> >> With "echo threaded > B/cgroup.type": >> >> Root - A (threaded domain) - B (threaded) >> \ C (domain, invalid) > Yes, I noted that when I was replying to Peter. > >> Any children of a threaded cgroup should be threaded. > It's really difficult to discuss if you just declare that something > should be a certain way without giving rationale for thinking so. > > If we could get rid of the invalid state completely that way, I'd > completely agree with you but that isn't the case here as you noted > yourself, so the choice between the two isn't something trivially > clear. Both choices come with their pros and cons. We can absoultely > discuss them comparing the pros and cons. I am not advocating on removing the invalid state now as I note about sibling cgroups. I am just saying that there is no point in not doing an automatic conversion to threaded for newly created children of threaded cgroups (not thread root). I don't see any cons in doing that. Cheers, Longman
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support Waiman Long <longman@redhat.com> - 2017-07-18 16:40 +0200
Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support Tejun Heo <tj@kernel.org> - 2017-07-18 19:20 +0200
Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support Waiman Long <longman@redhat.com> - 2017-07-18 19:30 +0200
Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support Tejun Heo <tj@kernel.org> - 2017-07-19 18:30 +0200
Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support Waiman Long <longman@redhat.com> - 2017-07-19 19:10 +0200
Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support Tejun Heo <tj@kernel.org> - 2017-07-19 19:50 +0200
csiph-web