Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690404

[PATCH v2 07/16] ntb: ntb_test: ensure the link is up before trying to configure the mws

Show all headers | View raw

After the link tests, there is a race on one side of the test for
the link coming up. It's possible, in some cases, for the test script
to write to the 'peer_trans' files before the link has come up.

To fix this, we simply use the link event file to ensure both sides
see the link as up before continuning.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
 tools/testing/selftests/ntb/ntb_test.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index 1c12b5855e4f..5fc7ad359e21 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -333,6 +333,10 @@ function ntb_tool_tests()
 	link_test $LOCAL_TOOL $REMOTE_TOOL
 	link_test $REMOTE_TOOL $LOCAL_TOOL
 
+	#Ensure the link is up on both sides before continuing
+	write_file Y $LOCAL_TOOL/link_event
+	write_file Y $REMOTE_TOOL/link_event
+
 	for PEER_TRANS in $(ls $LOCAL_TOOL/peer_trans*); do
 		PT=$(basename $PEER_TRANS)
 		write_file $MW_SIZE $LOCAL_TOOL/$PT
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/16] Switchtec NTB Support Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 12/16] switchtec_ntb: add link management Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 04/16] switchtec: add link event notifier callback Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 11/16] switchtec_ntb: add skeleton NTB driver Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 15/16] switchtec_ntb: add memory window support Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 13/16] switchtec_ntb: implement doorbell registers Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 07/16] ntb: ntb_test: ensure the link is up before trying to configure the mws Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 02/16] switchtec: export class symbol for use in upper layer driver Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 03/16] switchtec: add NTB hardware register definitions Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 16/16] switchtec_ntb: update switchtec documentation with notes for NTB Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  [PATCH v2 01/16] switchtec: move structure definitions into a common header Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 18:10 +0200
  RE: [PATCH v2 00/16] Switchtec NTB Support "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-07-18 20:00 +0200
    Re: [PATCH v2 00/16] Switchtec NTB Support Logan Gunthorpe <logang@deltatee.com> - 2017-07-18 20:10 +0200

csiph-web