Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1690385

Re: [PATCH] dmaengine: ioat: constify pci_device_id.

From Vinod Koul <vinod.koul@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] dmaengine: ioat: constify pci_device_id.
Date 2017-07-18 18:00 +0200
Message-ID <u4D4K-4gb-13@gated-at.bofh.it> (permalink)
References <u4gKT-7hy-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jul 17, 2017 at 09:39:00PM +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   12582	   3056	     16	  15654	   3d26	drivers/dma/ioat/init.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   14773	    865	     16	  15654	   3d26	drivers/dma/ioat/init.o

Applied, thanks

-- 
~Vinod

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] dmaengine: ioat: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 18:10 +0200
  Re: [PATCH] dmaengine: ioat: constify pci_device_id. Vinod Koul <vinod.koul@intel.com> - 2017-07-18 18:00 +0200

csiph-web