Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690365

Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level with runtime-time

From "Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups linux.kernel
Subject Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level with runtime-time
Date 2017-07-18 17:20 +0200
Message-ID <u4Cs1-41M-11@gated-at.bofh.it> (permalink)
References <u4BvX-3ta-3@gated-at.bofh.it> <u4BvY-3ta-19@gated-at.bofh.it> <u4BFD-3wF-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 18, 2017 at 04:24:06PM +0200, Juergen Gross wrote:
> On 18/07/17 16:15, Kirill A. Shutemov wrote:
> > diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
> > index cab28cf2cffb..b0530184c637 100644
> > --- a/arch/x86/xen/mmu_pv.c
> > +++ b/arch/x86/xen/mmu_pv.c
> > @@ -1209,7 +1209,7 @@ static void __init xen_cleanmfnmap(unsigned long vaddr)
> >  			continue;
> >  		xen_cleanmfnmap_p4d(p4d + i, unpin);
> >  	}
> > -	if (IS_ENABLED(CONFIG_X86_5LEVEL)) {
> > +	if (!p4d_folded) {
> >  		set_pgd(pgd, __pgd(0));
> >  		xen_cleanmfnmap_free_pgtbl(p4d, unpin);
> >  	}
> 
> Xen PV guests will never run with 5-level-paging enabled. So I guess you
> can drop the complete if (IS_ENABLED(CONFIG_X86_5LEVEL)) {} block.

Thanks.

I'll do a sparate cleanup patch for this.

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level with runtime-time "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-07-18 16:20 +0200
  Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level  with runtime-time Juergen Gross <jgross@suse.com> - 2017-07-18 16:30 +0200
    Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level  with runtime-time "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-07-18 17:20 +0200
    Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level  with runtime-time "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-07-25 11:10 +0200
      Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level  with runtime-time Juergen Gross <jgross@suse.com> - 2017-07-26 09:30 +0200
        Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level  with runtime-time "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-07-26 18:50 +0200
          Re: [PATCHv2 08/10] x86/mm: Replace compile-time checks for 5-level  with runtime-time Juergen Gross <jgross@suse.com> - 2017-07-27 10:30 +0200

csiph-web