Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

From	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context
Date	2017-07-18 17:30 +0200
Message-ID	<u4CBH-45e-11@gated-at.bofh.it> (permalink)
References	<u1GBQ-5sk-25@gated-at.bofh.it> <u4A6S-2tH-13@gated-at.bofh.it> <u4ATf-2Z9-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Alexey Budankov <alexey.budankov@linux.intel.com> writes:

>> You probably also want to explain this change, for example change the
>> @group_list description, saying that something else links into it now.
>> 
>
> The whole patch as a single commit, attached to patch v5 4/4, may provide
> the complete view of suggested changes.

No, each patch has to be readable on its own. If one has to jump between
patches to figure out what's going on, it's already discouraging. The
point of submitting a patch, on the other hand, is to encourage the
reviewers to read on.

Regards,
--
Alex

Thread

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-07-18 14:50 +0200
  Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees  for pinned and flexible groups at perf_event_context Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-07-18 15:40 +0200
    Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-07-18 17:30 +0200
      Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees  for pinned and flexible groups at perf_event_context Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-07-18 17:40 +0200

csiph-web