Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690289

Re: [PATCH v3 4/4] w1: ds1wm: add messages to make incorporation in mfd-drivers easier

Show all headers | View raw

On Tue, Jul 18, 2017 at 01:26:53PM +0200, Johannes Poehlmann wrote:
> Signed-off-by: Johannes Poehlmann <johannes.poehlmann@izt-labs.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
>  drivers/w1/masters/ds1wm.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)

And here as well.



> 
> diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
> index 7cb4460..76b4573 100644
> --- a/drivers/w1/masters/ds1wm.c
> +++ b/drivers/w1/masters/ds1wm.c
> @@ -580,8 +580,14 @@ static int ds1wm_probe(struct platform_device *pdev)
>  
>  	ret = devm_request_irq(&pdev->dev, ds1wm_data->irq, ds1wm_isr,
>  			IRQF_SHARED, "ds1wm", ds1wm_data);
> -	if (ret)
> +	if (ret) {
> +		dev_err(&ds1wm_data->pdev->dev,
> +			"devm_request_irq %d failed with errno %d\n",
> +			ds1wm_data->irq,
> +			ret);
> +
>  		return ret;
> +	}
>  
>  	ds1wm_up(ds1wm_data);
>  
> @@ -591,6 +597,13 @@ static int ds1wm_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err;
>  
> +	dev_info(&ds1wm_data->pdev->dev,
> +		"ds1wm: probe successful, IAS: %d, rec.delay: %d, clockrate: %d, bus-shift: %d, is Hw Big Endian: %d\n",
> +		plat->active_high,
> +		plat->reset_recover_delay,
> +		plat->clock_rate,
> +		ds1wm_data->bus_shift,
> +		ds1wm_data->is_hw_big_endian);

Ick, why be so noisy?  Drivers should be quiet unless something bad
happens, they should not print random things when devices are found if
at all possible.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/4] w1: ds1wm: add messages to make incorporation in mfd-drivers easier Johannes Poehlmann <johannes.poehlmann@izt-labs.de> - 2017-07-18 13:30 +0200
  Re: [PATCH v3 4/4] w1: ds1wm: add messages to make incorporation in  mfd-drivers easier Greg Kroah-Hartman <greg@kroah.com> - 2017-07-18 16:20 +0200

csiph-web