Re: [PATCH] gpio-exar: Use correct property prefix and document bindings

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio-exar: Use correct property prefix and document bindings
Date	2017-07-18 16:40 +0200
Message-ID	<u4BPk-3zB-27@gated-at.bofh.it> (permalink)
References	<u2G6K-2a4-27@gated-at.bofh.it> <u4ijE-85t-13@gated-at.bofh.it> <u4iWm-7E-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 17, 2017 at 1:20 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-07-17 19:48, Rob Herring wrote:
>> On Thu, Jul 13, 2017 at 08:44:26AM +0200, Jan Kiszka wrote:
>>> The device-specific property should be prefixed with the vendor name
>>> Change this and document the bindings of this platform device.
>>
>> You are breaking backwards compatibility. You minimally need to state
>> that and why that is okay in this case.
>
> There is no previous version yet: The patch that introduced this just
> entered for 4.13. Linus remarked that "linux," is the wrong prefix and
> wanted this to be changed before this version becomes final.

Please describe this in the commit message and add a Fixes tag.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio-exar: Use correct property prefix and document bindings Jan Kiszka <jan.kiszka@siemens.com> - 2017-07-13 08:50 +0200
  Re: [PATCH] gpio-exar: Use correct property prefix and document  bindings Rob Herring <robh@kernel.org> - 2017-07-17 19:50 +0200
    Re: [PATCH] gpio-exar: Use correct property prefix and document  bindings Jan Kiszka <jan.kiszka@siemens.com> - 2017-07-17 20:30 +0200
      Re: [PATCH] gpio-exar: Use correct property prefix and document bindings Rob Herring <robh@kernel.org> - 2017-07-18 16:40 +0200

csiph-web