Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688648

Re: [PATCH] mmc: mxcmmc: fix error return code in mxcmci_probe()

Show all headers | View raw

Hi Ulf,

On 07/11/2017 09:43 AM, Ulf Hansson wrote:
> On 7 July 2017 at 07:59, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>> platform_get_irq() returns an error code, but the mxcmmc driver
>> ignores it and always returns -EINVAL. This is not correct,
>> and prevents -EPROBE_DEFER from being propagated properly.
>>
>> Print error message and propagate the return value of
>> platform_get_irq on failure.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Thanks, applied for next!
>

Thank you!

> Kind regards
> Uffe
>
>> ---
>>  drivers/mmc/host/mxcmmc.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
>> index fb3ca82..f3c2832 100644
>> --- a/drivers/mmc/host/mxcmmc.c
>> +++ b/drivers/mmc/host/mxcmmc.c
>> @@ -1014,8 +1014,10 @@ static int mxcmci_probe(struct platform_device *pdev)
>>
>>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>         irq = platform_get_irq(pdev, 0);
>> -       if (irq < 0)
>> -               return -EINVAL;
>> +       if (irq < 0) {
>> +               dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
>> +               return irq;
>> +       }
>>
>>         mmc = mmc_alloc_host(sizeof(*host), &pdev->dev);
>>         if (!mmc)
>> --
>> 2.5.0
>>

-- 
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: mxcmmc: fix error return code in mxcmci_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-07 08:00 +0200
  Re: [PATCH] mmc: mxcmmc: fix error return code in mxcmci_probe() Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-11 16:50 +0200
    Re: [PATCH] mmc: mxcmmc: fix error return code in mxcmci_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 07:00 +0200

csiph-web