Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure
Date	2017-07-17 06:20 +0200
Message-ID	<u45FL-6o-3@gated-at.bofh.it> (permalink)
References	<u27LI-5Eg-17@gated-at.bofh.it> <u2vl1-3O6-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/12/2017 02:13 PM, Eric Anholt wrote:
> "Gustavo A. R. Silva" <garsilva@embeddedor.com> writes:
>
>> This structure is only used to copy into other structure, so declare
>> it as const.
>>
>> This issue was detected using Coccinelle and the following semantic patch:
> Acked-by: Eric Anholt <eric@anholt.net>

Thank you, Eric

>> ---
>>   drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
>> index 2308831..7203f35 100644
>> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
>> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
>> @@ -353,7 +353,7 @@ static int bcm2835_gpio_direction_output(struct gpio_chip *chip,
>>   	return pinctrl_gpio_direction_output(chip->base + offset);
>>   }
>>   
>> -static struct gpio_chip bcm2835_gpio_chip = {
>> +static const struct gpio_chip bcm2835_gpio_chip = {
>>   	.label = MODULE_NAME,
>>   	.owner = THIS_MODULE,
>>   	.request = gpiochip_generic_request,
>> -- 
>> 2.5.0

-- 
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: bcm2835: constify gpio_chip structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-11 20:10 +0200
  Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure Eric Anholt <eric@anholt.net> - 2017-07-12 21:20 +0200
    Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 06:20 +0200

csiph-web