Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687921

Re: [PATCH 4.4 00/57] 4.4.77-stable review

Show all headers | View raw

Hi Greg,

On Fri, Jul 14, 2017 at 3:26 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Jul 14, 2017 at 02:21:10PM +0200, Arnd Bergmann wrote:
>> On Fri, Jul 14, 2017 at 11:51 AM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > On Thu, Jul 13, 2017 at 02:07:45PM -0700, kernelci.org bot wrote:
>> >> stable-rc/linux-4.4.y boot: 99 boots: 1 failed, 92 passed with 5 offline, 1 conflict (v4.4.76-58-g1a12e8e8a429)
>> >
>> > Any idea how 0-day and Guenter's system found problems with this
>> > release, but you all didn't?  Do you not have any SH systems in
>> > kernelci?
>>
>> kernelci does not do any SH builds, but it did catch this driver in

Despite the sh-pfc name (from legacy "shmobile"), this is a pinctrl driver
for an ARM SoC.

>> the allmodconfig
>> builds and a couple of ARM builds that use the same one, see the mail with
>> subject "stable-rc/linux-4.4.y build: 199 builds: 10 failed, 189
>> passed, 30 errors,
>> 4 warnings (v4.4.76-58-g1a12e8e8a429)":
>>
>> Errors summary:
>>
>>      10  drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:2: error: implicit
>> declaration of function 'PINMUX_IPSR_GPSR'
>> [-Werror=implicit-function-declaration]
>>      10  drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:28: error:
>> 'DVC_MUTE' undeclared here (not in a function)
>>      10  drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:19: error:
>> 'IP6_2_0' undeclared here (not in a function)
>
> Where is that email?  I never got that, I only got this email
> response...

BTW, both you and I should have received the following email from
kbuild test robot <fengguang.wu@intel.com>:

[linux-stable-rc:linux-4.4.y 4899/4940]
drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:2: error: implicit
declaration of function 'PINMUX_IPSR_GPSR'

Unfortunately I had a day off, so I couldn't reply in time that that commit
depends on commit e01678e35f4be547 ("pinctrl: sh-pfc: Rename
PINMUX_IPSR_DATA() to PINMUX_IPSR_GPSR()"). As that one is
a bit heavy to backport, an alternative way to backport
3908632fb829d733 ("pinctrl: sh-pfc: r8a7791: Add missing DVC_MUTE signal")
is this (gmail-webinterface-whitespace-damaged) diff:

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
index 3d0490392adb7fb2..3d9e36ebcc6c6913 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -1093,7 +1093,7 @@ static const u16 pinmux_data[] = {
        PINMUX_IPSR_MSEL(IP6_2_0, STP_OPWM_0_B, SEL_SSP_1),
        PINMUX_IPSR_MSEL(IP6_2_0, MSIOF1_SCK_B, SEL_SOF1_1),
        PINMUX_IPSR_MSEL(IP6_2_0, SCIF_CLK, SEL_SCIF_0),
-       PINMUX_IPSR_GPSR(IP6_2_0, DVC_MUTE),
+       PINMUX_IPSR_DATA(IP6_2_0, DVC_MUTE),
        PINMUX_IPSR_MSEL(IP6_2_0, BPFCLK_E, SEL_FM_4),
        PINMUX_IPSR_DATA(IP6_5_3, AUDIO_CLKC),
        PINMUX_IPSR_MSEL(IP6_5_3, SCIFB0_SCK_C, SEL_SCIFB_2),

However, as probably nobody uses the DVC_MUTE signal, dropping its
backporting should be OK, too.

Sorry for the fuzz...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 27/57] ath10k: override CE5 config for QCA9377 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 12/57] usb: Fix typo in the definition of Endpoint[out]Request Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 50/57] md: fix incorrect use of lexx_to_cpu in does_sb_need_changing Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 54/57] staging: comedi: fix clean-up of comedi_class in comedi_init() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 11/57] usb: usbip: set buffer pointers to NULL after free Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 45/57] perf pmu: Fix misleadingly indented assignment (whitespace) Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 17:50 +0200
  [PATCH 4.4 13/57] mac80211_hwsim: Replace bogus hrtimer clockid Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 39/57] perf bench numa: Avoid possible truncation when using snprintf() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 10/57] Add USB quirk for HVR-950q to avoid intermittent device resets Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 06/57] tracing/kprobes: Allow to create probe with a module name starting with a digit Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 02/57] fs: completely ignore unknown open flags Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 09/57] USB: serial: cp210x: add ID for CEL EM3588 USB ZigBee stick Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 43/57] perf tools: Remove duplicate const qualifier Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 31/57] tools include: Add a __fallthrough statement Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 16/57] pinctrl: sh-pfc: r8a7791: Fix SCIF2 pinmux data Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 15/57] sysctl: report EINVAL if value is larger than UINT_MAX for proc_douintvec Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 37/57] perf scripting perl: Fix compile error with some perl5 versions Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 41/57] perf thread_map: Use readdir() instead of deprecated readdir_r() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 01/57] fs: add a VALID_OPEN_FLAGS Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 40/57] perf tools: Use readdir() instead of deprecated readdir_r() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 34/57] perf top: Use __fallthrough Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 33/57] tools strfilter: Use __fallthrough Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 32/57] tools string: Use __fallthrough in perf_atoll() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 19/57] pinctrl: sunxi: Fix SPDIF function name for A83T Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 35/57] perf intel-pt: Use __fallthrough Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  [PATCH 4.4 17/57] pinctrl: sh-pfc: r8a7791: Add missing DVC_MUTE signal Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-13 18:00 +0200
  Re: [PATCH 4.4 00/57] 4.4.77-stable review Guenter Roeck <linux@roeck-us.net> - 2017-07-14 03:40 +0200
    Re: [PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-14 12:00 +0200
      Re: [PATCH 4.4 00/57] 4.4.77-stable review Guenter Roeck <linux@roeck-us.net> - 2017-07-14 21:30 +0200
        Re: [PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-15 10:20 +0200
  Re: [PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-14 12:00 +0200
    Re: [PATCH 4.4 00/57] 4.4.77-stable review Arnd Bergmann <arnd@arndb.de> - 2017-07-14 14:30 +0200
      Re: [PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-14 15:30 +0200
        Re: [PATCH 4.4 00/57] 4.4.77-stable review Arnd Bergmann <arnd@arndb.de> - 2017-07-14 22:00 +0200
        Re: [PATCH 4.4 00/57] 4.4.77-stable review Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-15 13:20 +0200
          Re: [PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-15 13:30 +0200
    Re: [PATCH 4.4 00/57] 4.4.77-stable review Mark Brown <broonie@kernel.org> - 2017-07-14 14:40 +0200
      Re: [PATCH 4.4 00/57] 4.4.77-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-14 15:30 +0200

csiph-web