Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687716

[PATCH net 0/2] Fragmented SKB corrections

Show all headers | View raw

Two issues were observed in a review of the bcmgenet driver support for
fragmented SKBs which are addressed by this patch set.

The first addresses a problem that could occur if the driver is not able
to DMA map a fragment of the SKB.  This would be a highly unusual event
but it would leave the hardware descriptors in an invalid state which
should be prevented.

The second is a hazard that could occur if the driver is able to reclaim
the first control block of a fragmented SKB before all of its fragments
have completed processing by the hardware.  In this case the SKB could
be freed leading to reuse of memory that is still in use by hardware.

Doug Berger (2):
  net: bcmgenet: Fix unmapping of fragments in bcmgenet_xmit()
  net: bcmgenet: Free skb after last Tx frag

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 299 +++++++++++++------------
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   2 +
 2 files changed, 152 insertions(+), 149 deletions(-)

-- 
2.13.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net 0/2] Fragmented SKB corrections Doug Berger <opendmb@gmail.com> - 2017-07-15 01:20 +0200
  [PATCH net 2/2] net: bcmgenet: Free skb after last Tx frag Doug Berger <opendmb@gmail.com> - 2017-07-15 01:20 +0200
  [PATCH net 1/2] net: bcmgenet: Fix unmapping of fragments in bcmgenet_xmit() Doug Berger <opendmb@gmail.com> - 2017-07-15 01:20 +0200
  Re: [PATCH net 0/2] Fragmented SKB corrections David Miller <davem@davemloft.net> - 2017-07-16 06:40 +0200

csiph-web