Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling

From	Ilia Mirkin <imirkin@alum.mit.edu>
Newsgroups	linux.kernel
Subject	Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling
Date	2017-07-16 18:00 +0200
Message-ID	<u3U7D-Ze-3@gated-at.bofh.it> (permalink)
References	<u3o7L-5WL-3@gated-at.bofh.it> <u3Ash-51n-7@gated-at.bofh.it> <u3JFf-2u5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 16, 2017 at 12:43 AM, Mike Galbraith <efault@gmx.de> wrote:
> On Sat, 2017-07-15 at 14:52 -0400, Ilia Mirkin wrote:
>>
>> OK, so this issue appears to be that we're calling
>> drm_crtc_vblank_off() on a crtc for which vblank is already disabled.
>> My guess is that this happens because the crtc is disabled.
>>
>> Not sure what the proper check is to see if vblanks are already disabled...
>
> Seems so, the below shut up suspend for both 8600 GT and GTX 980.

The modeset done by drm_atomic_helper_suspend (called previously to
that *_fini) should already take care of disabling vblanks, I think.
So the vblank_off calls can just be done when we're not doing an
atomic modeset [drm_drv_uses_atomic_modeset(dev)] -- this is all very
confusing since pre-nv50 uses legacy modesets, while nv50+ has been
moved to atomic, but they share a bunch of helpers =/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[drm/nouveau] GeForce 8600 GT boot/suspend grumbling Mike Galbraith <efault@gmx.de> - 2017-07-15 07:50 +0200
  Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-15 18:20 +0200
    Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-15 20:20 +0200
  Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-15 21:00 +0200
    Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling Mike Galbraith <efault@gmx.de> - 2017-07-16 06:50 +0200
      Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-16 18:00 +0200

csiph-web