Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688016

Re: [PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> On Sat, 2017-07-15 at 11:39 -0400, James Simmons wrote:
> > Cleanup all braces that was reported by checkpatch. The only
> > issue not fixed up is in mdc_lock.c. Removing the braces in
> > the case of mdc_lock.c will break the build.
> 
> what checkpatch warning in mdc_locks.c is that?
> 
> $ ./scripts/checkpatch.pl -f --terse --nosummary drivers/staging/lustre/lustre/mdc/mdc_locks.c 
> drivers/staging/lustre/lustre/mdc/mdc_locks.c:590: WARNING: line over 80 characters
> drivers/staging/lustre/lustre/mdc/mdc_locks.c:600: WARNING: line over 80 characters
> drivers/staging/lustre/lustre/mdc/mdc_locks.c:637: WARNING: line over 80 characters

For 4.11-xxx kernels I was seeing

WARNING: braces {} are not necessary for any arm of this statement
#914: FILE: drivers/staging/lustre/lustre/mdc/mdc_locks.c:914:
+       if (it->it_op & IT_CREAT) {
[...]
+       } else if (it->it_op == IT_OPEN) {
[...]
+       } else {
[...]

Now it doesn't show up.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch James Simmons <jsimmons@infradead.org> - 2017-07-15 17:40 +0200
  Re: [PATCH] staging: lustre: lustre: fix all braces issues reported  by checkpatch Joe Perches <joe@perches.com> - 2017-07-15 18:00 +0200
    Re: [PATCH] staging: lustre: lustre: fix all braces issues reported  by checkpatch James Simmons <jsimmons@infradead.org> - 2017-07-16 01:10 +0200
  Re: [PATCH] staging: lustre: lustre: fix all braces issues reported  by checkpatch Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-17 14:30 +0200

csiph-web