Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688002

Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> On Jul 15, 2017, at 1:07 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> 
> Drop static on a local variable, when the variable is initialized before
> any possible use.  Thus, the static has no benefit.

I think this is in error like the other one. I believe that the irq_chip structure needs a persistent lifetime.

> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
> static T x@p;
> ...
> x = <+...x...+>
> 
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
> -static
> T x@p;
> ... when != x
>     when strict
> ?x = e;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
> These patches are all independent of each other.
> 
> drivers/irqchip/irq-mips-cpu.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -u -p a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c
> --- a/drivers/irqchip/irq-mips-cpu.c
> +++ b/drivers/irqchip/irq-mips-cpu.c
> @@ -154,7 +154,7 @@ asmlinkage void __weak plat_irq_dispatch
> static int mips_cpu_intc_map(struct irq_domain *d, unsigned int irq,
> 			     irq_hw_number_t hw)
> {
> -	static struct irq_chip *chip;
> +	struct irq_chip *chip;
> 
> 	if (hw < 2 && cpu_has_mipsmt) {
> 		/* Software interrupts are used for MT/CMT IPI */
> 

--
Mark Rustad, MRustad@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] Drop unnecessary static Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-15 22:40 +0200
  [PATCH 08/11] ata: Drop unnecessary static Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-15 22:40 +0200
  [PATCH 03/11] mtd: physmap_of: Drop unnecessary static Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-15 22:40 +0200
    Re: [PATCH 03/11] mtd: physmap_of: Drop unnecessary static Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-07-17 22:00 +0200
  [PATCH 01/11] clk: mmp: Drop unnecessary static Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-15 22:40 +0200
    Re: [PATCH 01/11] clk: mmp: Drop unnecessary static Stephen Boyd <sboyd@codeaurora.org> - 2017-07-18 03:40 +0200
  [PATCH 04/11] fbdev: da8xx-fb: Drop unnecessary static Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-15 22:40 +0200
  [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-15 22:40 +0200
    Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static Mark D Rustad <mrustad@gmail.com> - 2017-07-15 23:00 +0200
      Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static Julia Lawall <julia.lawall@lip6.fr> - 2017-07-15 23:00 +0200
        Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static Mark D Rustad <mrustad@gmail.com> - 2017-07-16 08:10 +0200

csiph-web