Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687458

Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if in init section

Show key headers only | View raw

On 14/07/17 13:40, Petr Mladek wrote:
> On Wed 2017-07-12 13:11:17, Petr Mladek wrote:
>> On Tue 2017-07-11 15:41:50, Matt Redfearn wrote:
>>> On 11/07/17 13:43, Petr Mladek wrote:
>>>> IMHO, the reasonable solution is to move early console code and data
>>>> out of the init sections. We should do this for the early consoles
>>>> where the corresponding real console is registered using a deferred
>>>> probe. Others should be already replaced by the real console when
>>>> printk_late_init() is called. At least this is how I understand it.
>>> This seems like the most reasonable way forward to me as well,
>>> though sadly will lead to some post-init kernel bloat.
>>>
>>> I still think, however, that this patch is a reasonable change to
>>> make.
>> The thing is that this patch "silently" makes the keep_bootcon
>> option almost unusable.
> I was wrong here. I thought that most early consoles used the init
> section. It was mentioned somewhere and I looked a wrong way.
> But this is not true. In fact, it seems that there are
> only few of them. Most early consoles have struct console
> and the write() callback in the normal section that is preserved.
>
> Matt's patch and the keep_bootcon option makes sense to me
> after all. Let me to resend Matt's patch with some small
> improvements and one more patch that improves the check
> of early consoles that use init section. I'll keep Matt
> as the author of the first patch.

Thanks for looking into this and your fix Petr!

Matt

>
> Best Regards,
> Petr
>   

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] printk: Unconditionally unregister boot consoles if in init section Matt Redfearn <matt.redfearn@imgtec.com> - 2017-07-06 12:40 +0200
  [PATCH 2/2] serial: earlycon: Make early_con as __initdata Matt Redfearn <matt.redfearn@imgtec.com> - 2017-07-06 12:40 +0200
    Re: [PATCH 2/2] serial: earlycon: Make early_con as __initdata Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-07-07 06:50 +0200
  Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-07-07 06:50 +0200
    Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Matt Redfearn <matt.redfearn@imgtec.com> - 2017-07-07 10:00 +0200
      Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Petr Mladek <pmladek@suse.com> - 2017-07-11 14:50 +0200
        Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Matt Redfearn <matt.redfearn@imgtec.com> - 2017-07-11 16:50 +0200
          Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Petr Mladek <pmladek@suse.com> - 2017-07-12 13:20 +0200
            Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Petr Mladek <pmladek@suse.com> - 2017-07-14 14:50 +0200
              Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Matt Redfearn <matt.redfearn@imgtec.com> - 2017-07-14 16:00 +0200
        Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if  in init section Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-07-15 00:00 +0200

csiph-web