Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687471

Re: [PATCH V4] PCI: handle CRS returned by device after FLR

Show all headers | View raw

On 7/13/2017 7:38 PM, Bjorn Helgaas wrote:
>> This does not specify a hard limit above on how long SW need to wait. 
> I wouldn't expect a *maximum* time we can wait.  I'm looking for the
> minimum times the spec requires.

My understanding is FLR needs to finish in 100ms max under normal circumstances.
If an endpoint needs more, it needs to issue CRS.

	"After an FLR has been initiated by writing a 1b to the Initiate Function Level Reset bit, 
	the Function must complete the FLR within 100 ms. 

	...

	it is recommended that software allow as much time as provided by the pre-FLR value for Completion 
	Timeout on the device. If Completion Timeouts were disabled on the Function when FLR was issued, 
	then the delay is system dependent but must be no less than 100 ms."

The only minimum I found is in the last paragraph where somebody actually disables
completion timeout. I don't know why anyone would do that.

> 
> If you're claiming "the spec is calling to wait up to 1 second", I
> just want to know where in the spec it says that.  That helps in the
> future when we need to maintain code like this.
> 

Keith and I discussed this here. 

https://www.spinics.net/lists/arm-kernel/msg593493.html

We have a spec language problem. My interpretation of this is 1 seconds
max for CRS.

	"When used, DRS and FRS allow an improved behavior over the CRS mechanism, 
	and eliminate its associated periodic polling time of up to 1 second
	following a reset."

The ECN is referring to conventional reset as 1 second max rather than CRS.
	https://www.spinics.net/lists/arm-kernel/msg593500.html

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4] PCI: handle CRS returned by device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-07-06 23:10 +0200
  Re: [PATCH V4] PCI: handle CRS returned by device after FLR Bjorn Helgaas <helgaas@kernel.org> - 2017-07-13 14:20 +0200
    Re: [PATCH V4] PCI: handle CRS returned by device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-07-13 18:00 +0200
      Re: [PATCH V4] PCI: handle CRS returned by device after FLR Keith Busch <keith.busch@intel.com> - 2017-07-13 18:30 +0200
        Re: [PATCH V4] PCI: handle CRS returned by device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-07-13 18:50 +0200
          Re: [PATCH V4] PCI: handle CRS returned by device after FLR Keith Busch <keith.busch@intel.com> - 2017-07-13 19:20 +0200
      Re: [PATCH V4] PCI: handle CRS returned by device after FLR Bjorn Helgaas <helgaas@kernel.org> - 2017-07-14 01:40 +0200
        Re: [PATCH V4] PCI: handle CRS returned by device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-07-14 16:20 +0200
    Re: [PATCH V4] PCI: handle CRS returned by device after FLR Keith Busch <keith.busch@intel.com> - 2017-07-13 18:00 +0200
  Re: [PATCH V4] PCI: handle CRS returned by device after FLR Bjorn Helgaas <helgaas@kernel.org> - 2017-07-14 01:50 +0200
    Re: [PATCH V4] PCI: handle CRS returned by device after FLR Sinan Kaya <okaya@codeaurora.org> - 2017-07-14 16:30 +0200

csiph-web