Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1687373

Re: [PATCH v3 3/3] nvmet: preserve controller serial number between reboots

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH v3 3/3] nvmet: preserve controller serial number between reboots
Date 2017-07-14 15:00 +0200
Message-ID <u38mm-3Ag-19@gated-at.bofh.it> (permalink)
References <u38ml-3Ag-5@gated-at.bofh.it> <u38mm-3Ag-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> +	down_write(&nvmet_config_sem);
>  	subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */
>  	/* generate a random serial number as our controllers are ephemeral: */
>  	get_random_bytes(&subsys->serial, sizeof(subsys->serial));
> +	up_write(&nvmet_config_sem);

no need for the lock here, the subsystems isn't visible at this point.

Otherwise:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v3 3/3] nvmet: preserve controller serial number         between reboots Christoph Hellwig <hch@lst.de> - 2017-07-14 15:00 +0200

csiph-web