Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1687342
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots |
| Date | 2017-07-14 14:40 +0200 |
| Message-ID | <u3830-3qu-21@gated-at.bofh.it> (permalink) |
| References | <u37zY-3en-21@gated-at.bofh.it> <u37zY-3en-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> static struct configfs_attribute *nvmet_subsys_attrs[] = {
> &nvmet_subsys_attr_attr_allow_any_host,
> &nvmet_subsys_attr_version,
> + &nvmet_subsys_attr_attr_serial,
but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up. And we should also add nvmetcli support
for it. Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/2] nvmet: preserve controller serial number between reboots Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-14 14:10 +0200
Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Christoph Hellwig <hch@lst.de> - 2017-07-14 14:40 +0200
Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Christoph Hellwig <hch@lst.de> - 2017-07-14 14:50 +0200
Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-14 14:50 +0200
csiph-web