Re: [PATCH v2 1/2] nvmet: Move serial number from controller to subsystem

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] nvmet: Move serial number from controller to subsystem
Date	2017-07-14 14:40 +0200
Message-ID	<u382Z-3qu-7@gated-at.bofh.it> (permalink)
References	<u37zY-3en-21@gated-at.bofh.it> <u37A1-3en-113@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -	/* generate a random serial number as our controllers are ephemeral: */
> -	get_random_bytes(&ctrl->serial, sizeof(ctrl->serial));
> -
>  	kref_init(&ctrl->ref);
>  	ctrl->subsys = subsys;
>  
> @@ -928,6 +925,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn,
>  		return NULL;
>  
>  	subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */
> +	get_random_bytes(&subsys->serial, sizeof(subsys->serial));

This removes the comment, which I think is fairly useful.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] Provide a stable serial number Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-14 14:10 +0200
  [PATCH v2 1/2] nvmet: Move serial number from controller to subsystem Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-14 14:10 +0200
    Re: [PATCH v2 1/2] nvmet: Move serial number from controller to         subsystem Christoph Hellwig <hch@lst.de> - 2017-07-14 14:40 +0200

csiph-web