Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1687172

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

From Jani Nikula <jani.nikula@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches
Date 2017-07-14 11:10 +0200
Message-ID <u34LM-1gd-31@gated-at.bofh.it> (permalink)
References (3 earlier) <u2C38-84q-27@gated-at.bofh.it> <u2JnY-4lu-21@gated-at.bofh.it> <u2Pa2-7UJ-21@gated-at.bofh.it> <u2Qps-cO-15@gated-at.bofh.it> <u2Srh-1rA-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 13 Jul 2017, Stéphane Marchesin <stephane.marchesin@gmail.com> wrote:
> So, if you think this is wrong, can you fix this warning in a way that
> you'd like?

As I replied previously [1], with more background, fixing the warnings
properly, in a way that actually improves the code instead of making it
worse, would mean a bunch of churn that's not just purely mechanical
conversion.

Unless you can point out a bug which is actually caused by mixing the
types (which is mostly intentional, see the background) I have a hard
time telling people this should be a priority. Definitely something we'd
like to do in the long run and pedantically correct (and I tend to
prefer code that way) but we certainly have more important things to do.

BR,
Jani.

[1] http://mid.mail-archive.com/87wp9rahjy.fsf@intel.com


-- 
Jani Nikula, Intel Open Source Technology Center

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Stéphane Marchesin <marcheu@chromium.org> - 2017-07-13 04:30 +0200
  Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-07-13 12:20 +0200
    Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Daniel Vetter <daniel@ffwll.ch> - 2017-07-13 14:30 +0200
    Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Stéphane Marchesin <marcheu@chromium.org> - 2017-07-13 18:30 +0200
      Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-07-13 19:50 +0200
        Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Stéphane Marchesin <stephane.marchesin@gmail.com> - 2017-07-13 22:00 +0200
          Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Jani Nikula <jani.nikula@linux.intel.com> - 2017-07-14 11:10 +0200
            Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Grant Grundler <grundler@chromium.org> - 2017-07-14 19:40 +0200
              Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Daniel Vetter <daniel@ffwll.ch> - 2017-07-14 23:40 +0200
                Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Grant Grundler <grundler@chromium.org> - 2017-07-15 00:50 +0200
                Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Matthias Kaehlcke <mka@chromium.org> - 2017-07-15 01:40 +0200

csiph-web