Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID

From	Florian Westphal <fw@strlen.de>
Newsgroups	linux.kernel
Subject	Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID
Date	2017-07-13 00:30 +0200
Message-ID	<u2yiS-5DX-11@gated-at.bofh.it> (permalink)
References	(2 earlier) <tYa5r-1ah-3@gated-at.bofh.it> <tYaf7-1dM-5@gated-at.bofh.it> <tYaI9-1Ck-11@gated-at.bofh.it> <tYnYJ-1T5-5@gated-at.bofh.it> <u2xmO-53z-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Richard Weinberger <richard@nod.at> wrote:
> Am 01.07.2017 um 12:35 schrieb Florian Westphal:
> > The compare on removal is not needed afaics, and its also not used when
> > doing lookup to begin with, so we can just recompute it?
> 
> Isn't this a way too much overhead?

I don't think so.  This computation only occurs when we dump events
to userspace.

> I personally favor Pablo's per-cpu counter approach.
> That way the IDs are unique again and we get rid of the info leak without
> much effort.

I have not seen these patches so can't really comment.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID Richard Weinberger <richard@nod.at> - 2017-07-12 23:30 +0200
  Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID Florian Westphal <fw@strlen.de> - 2017-07-13 00:30 +0200

csiph-web