Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686053

Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

Show all headers | View raw

From: Dave Hansen <dave.hansen@linux.intel.com>
Date: Wed, 12 Jul 2017 14:09:25 -0700

> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> I'm seeing warnings on kernel configurations where CONFIG_PM is
> disabled.  It happens in 4.12, at least:
> 
> drivers/ethernet/intel/igb/igb_main.c:7988:13: warning: 'igb_deliver_wake_packet' defined but not used [-Wunused-function]
> 
> This is because igb_deliver_wake_packet() is defined outside of
> the #ifdef", but is used only a single time within the #ifdef in
> igb_resume().  Fix it by moving igb_deliver_wake_packet() next to
> igb_resume() inside the #ifdef.
> 
> The diff ends up looking a bit funky here.  It *looks* like
> igb_suspend() is getting moved, but that's an artifact of how
> 'diff' sees the changes.
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

I'll let Jeff queue this up into his tree.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n Dave Hansen <dave.hansen@linux.intel.com> - 2017-07-12 23:20 +0200
  Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n Fabio Estevam <festevam@gmail.com> - 2017-07-12 23:30 +0200
    Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when  CONFIG_PM=n Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2017-07-14 00:40 +0200
  Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when  CONFIG_PM=n David Miller <davem@davemloft.net> - 2017-07-12 23:40 +0200

csiph-web