omap3isp: is capture mode working? what hardware? was Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	omap3isp: is capture mode working? what hardware? was Re: v4l2-fwnode: status, plans for merge, any branch to merge against?
Date	Wed, 12 Jul 2017 22:40:01 +0200
Message-ID	<u2wAp-4xB-7@gated-at.bofh.it> (permalink)
References	<tgyld-2jr-31@gated-at.bofh.it> <thhBD-15f-1@gated-at.bofh.it> <thVpn-4FY-1@gated-at.bofh.it> <tjBFT-25r-9@gated-at.bofh.it> <tRT7k-7UN-33@gated-at.bofh.it> <tRTqG-81T-11@gated-at.bofh.it> <tS1ez-4Bs-51@gated-at.bofh.it> <tSelr-4qx-3@gated-at.bofh.it> <tZxCG-1Bv-23@gated-at.bofh.it> <tZOWR-4rC-1@gated-at.bofh.it>
X-Original-To	Sakari Ailus <sakari.ailus@iki.fi>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	74
Organization	linux.* mail to news gateway
X-Original-Cc	Laurent Pinchart <laurent.pinchart@ideasonboard.com>, mchehab@kernel.org, kernel list <linux-kernel@vger.kernel.org>, ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org
X-Original-Date	Wed, 12 Jul 2017 22:31:05 +0200
X-Original-Message-ID	<20170712203105.GA26734@amd>
X-Original-References	<20170302123848.GA28230@amd> <20170304130318.GU3220@valkosipuli.retiisi.org.uk> <20170306072323.GA23509@amd> <20170310225418.GJ3220@valkosipuli.retiisi.org.uk> <20170613122240.GA2803@amd> <20170613124748.GD12407@valkosipuli.retiisi.org.uk> <20170613210900.GA31456@amd> <20170614110634.GP12407@valkosipuli.retiisi.org.uk> <20170704150819.GA10703@localhost> <20170705093248.hndchnamibhqczfr@valkosipuli.retiisi.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1686020

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> What I've done is just rebased the ccp2 branch. In other words, the patches
> in that branch are no more ready than they were.
> 
> To get these merged we should ideally
> 
> 1) Make sure there will be no regressions,

I grepped dts trees a bit... where is omap3isp currently used?
Anything besides N9 and N950?

Does the capture mode currently work for you?

Because as far as I can tell, formatter is disabled, so video is in
wrong format for the userspace.

So something like patch below is needed; (of course after adjusting
the comment etc.)

Thanks,
								Pavel

commit eb81524b8b44bbff2518b272cb3de304157bd3ba
Author: Pavel <pavel@ucw.cz>
Date:   Mon Feb 13 21:26:51 2017 +0100

    omap3isp: fix VP2SDR bit so capture (not preview) works
    
    This is neccessary for capture (not preview) to work properly on
    N900. Why is unknown.

diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
index 7207558..2fb755f 100644
--- a/drivers/media/platform/omap3isp/ispccdc.c
+++ b/drivers/media/platform/omap3isp/ispccdc.c
@@ -1186,7 +1186,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc)
 	/* Use the raw, unprocessed data when writing to memory. The H3A and
 	 * histogram modules are still fed with lens shading corrected data.
 	 */
-	syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR;
+//	syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR;
+	syn_mode |= ISPCCDC_SYN_MODE_VP2SDR;
 
 	if (ccdc->output & CCDC_OUTPUT_MEMORY)
 		syn_mode |= ISPCCDC_SYN_MODE_WEN;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Pavel Machek <pavel@ucw.cz> - 2017-07-04 17:10 +0200
  Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-05 11:40 +0200
    Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Pavel Machek <pavel@ucw.cz> - 2017-07-06 12:40 +0200
      Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-11 18:20 +0200
        Re: v4l2-fwnode: status, plans for merge, any branch to merge  against? Pavel Machek <pavel@ucw.cz> - 2017-07-12 18:40 +0200
    omap3isp: is capture mode working? what hardware? was Re:  v4l2-fwnode: status, plans for merge, any branch to merge against? Pavel Machek <pavel@ucw.cz> - 2017-07-12 22:40 +0200

csiph-web