Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case

From	Sylwester Nawrocki <snawrocki@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case
Date	2017-07-12 21:20 +0200
Message-ID	<u2vl0-3O6-7@gated-at.bofh.it> (permalink)
References	<tZ5Gq-7vd-13@gated-at.bofh.it> <tZ5Q8-7za-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/03/2017 11:16 AM, Hugues Fruchet wrote:
> Switch i2c device id to lower case as it is

s/i2c/I2C ?

> done for other omnivision cameras.

s/omnivision/Omnivision

This is required for properly matching driver with device on DT platforms,
right? It might be worth to mention that so it is clear why we break any
non-dt platform that could be already using this driver. There seem to be 
none in the mainline kernel tree though.

> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>

Reviewed-by: Sylwester Nawrocki <snawrocki@kernel.org>

> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
>   drivers/media/i2c/ov9650.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
> index 2de2fbb..1e4e99e 100644
> --- a/drivers/media/i2c/ov9650.c
> +++ b/drivers/media/i2c/ov9650.c
> @@ -1545,8 +1545,8 @@ static int ov965x_remove(struct i2c_client *client)
>   }
>   
>   static const struct i2c_device_id ov965x_id[] = {
> -	{ "OV9650", 0 },
> -	{ "OV9652", 0 },
> +	{ "ov9650", 0 },
> +	{ "ov9652", 0 },
>   	{ /* sentinel */ }
>   };
>   MODULE_DEVICE_TABLE(i2c, ov965x_id);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case Sylwester Nawrocki <snawrocki@kernel.org> - 2017-07-12 21:20 +0200

csiph-web