Re: [PATCH] slub: make sure struct kmem_cache_node is initialized before publication

From	Christopher Lameter <cl@linux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] slub: make sure struct kmem_cache_node is initialized before publication
Date	2017-07-12 22:00 +0200
Message-ID	<u2vXJ-45d-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <u0I2Z-DO-7@gated-at.bofh.it> <u0KHv-2xj-1@gated-at.bofh.it> <u1NDk-1kS-11@gated-at.bofh.it> <u2qEF-Q6-23@gated-at.bofh.it> <u2vuG-3Ri-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 12 Jul 2017, Andrew Morton wrote:

> - free_kmem_cache_nodes() frees the cache node before nulling out a
>   reference to it
>
> - init_kmem_cache_nodes() publishes the cache node before initializing it
>
> Neither of these matter at runtime because the cache nodes cannot be
> looked up by any other thread.  But it's neater and more consistent to
> reorder these.

The compiler or processor may reorder them at will anyways. But if its
tidier....

Acked-by: Christoph Lameter <cl@linux.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] slub: make sure struct kmem_cache_node is initialized before publication Alexander Potapenko <glider@google.com> - 2017-07-07 10:40 +0200
  Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Alexander Potapenko <glider@google.com> - 2017-07-07 10:50 +0200
  Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Andrew Morton <akpm@linux-foundation.org> - 2017-07-07 22:30 +0200
    Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Christoph Lameter <cl@linux.com> - 2017-07-08 01:20 +0200
      Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Alexander Potapenko <glider@google.com> - 2017-07-10 11:30 +0200
        Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Christoph Lameter <cl@linux.com> - 2017-07-10 17:40 +0200
      Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Andrew Morton <akpm@linux-foundation.org> - 2017-07-10 22:40 +0200
        Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Alexander Potapenko <glider@google.com> - 2017-07-12 16:20 +0200
          Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Andrew Morton <akpm@linux-foundation.org> - 2017-07-12 21:30 +0200
            Re: [PATCH] slub: make sure struct kmem_cache_node is initialized  before publication Christopher Lameter <cl@linux.com> - 2017-07-12 22:00 +0200

csiph-web