Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1685924
| From | Hans Ulli Kroll <ulli.kroll@googlemail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 11/22] rtc: gemini: stop using rtc deprecated functions |
| Date | 2017-07-12 19:30 +0200 |
| Message-ID | <u2tCy-2IA-5@gated-at.bofh.it> (permalink) |
| References | <u2kSB-5FA-3@gated-at.bofh.it> <u2kSC-5FA-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Benjamin,
On Wed, 12 Jul 2017, Benjamin Gaignard wrote:
> @@ -93,12 +93,12 @@ static int ftrtc010_rtc_set_time(struct device *dev, struct rtc_time *tm)
> {
> struct ftrtc010_rtc *rtc = dev_get_drvdata(dev);
> unsigned int sec, min, hour, day;
> - unsigned long offset, time;
> + unsigned long long offset, time;
>
> if (tm->tm_year >= 2148) /* EPOCH Year + 179 */
> return -EINVAL;
>
> - rtc_tm_to_time(tm, &time);
> + time = rtc_tm_to_time64(tm);
>
> sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND);
> min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE);
later on this will do
writel(offset, rtc->rtc_base + FTRTC010_RTC_RECORD);
you are writing some 64bit value in a 32bit register ...
NACK here
Greetings from Cologne
Hans Ulli Kroll
> 1.9.1
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 11/22] rtc: gemini: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-07-12 10:10 +0200 Re: [PATCH v2 11/22] rtc: gemini: stop using rtc deprecated functions Hans Ulli Kroll <ulli.kroll@googlemail.com> - 2017-07-12 19:30 +0200
csiph-web