Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685735

Re: [PATCH] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

Show all headers | View raw

On Wed, Jul 12, 2017 at 04:53:53PM +0530, Jaya Durga wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
> 
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
>  drivers/staging/speakup/speakup_keypc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> index d3203f8..1ba4cfc 100644
> --- a/drivers/staging/speakup/speakup_keypc.c
> +++ b/drivers/staging/speakup/speakup_keypc.c
> @@ -28,7 +28,7 @@
>  
>  #define DRV_VERSION "2.10"
>  #define SYNTH_IO_EXTENT	0x04
> -#define SWAIT udelay(70)
> +#define SWAIT usleep_range(70, 150)

Ick, why not just get rid of SWAIT entirely please?


>  #define PROCSPEECH 0x1f
>  #define SYNTH_CLEAR 0x03
>  
> @@ -164,7 +164,7 @@ static const char *synth_immediate(struct spk_synth *synth, const char *buf)
>  			if (--timeout <= 0)
>  				return oops();
>  		outb_p(ch, synth_port);
> -		udelay(70);
> +		usleep_range(70, 150);

And you are sure it is ok to wait up to 150 long here?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay Jaya Durga <rjdurga@gmail.com> - 2017-07-12 13:30 +0200
  Re: [PATCH] Staging: speakup: speakup_keypc.c: usleep_range is  preferred over udelay Greg KH <gregkh@linuxfoundation.org> - 2017-07-12 14:40 +0200
  Re: [PATCH] Staging: speakup: speakup_keypc.c: usleep_range is  preferred over udelay Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-07-12 14:40 +0200

csiph-web