Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685571

[PATCH 2/2] ftrace: silence uninitialized variable warning

Show all headers | View raw

My static checker complains that if "func" is NULL then "clear_filter"
is uninitialized.  This seems like it could be true, although it's
possible something subtle is happening that I haven't seen.

    kernel/trace/ftrace.c:3844 match_records()
    error: uninitialized symbol 'clear_filter'.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
It does occur to me that I could initialize it to 1 instead of 0 but my
guess is that zero is intended.  Please review this one carefully.

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 2a3c45743f54..5e658da91912 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -3816,7 +3816,7 @@ match_records(struct ftrace_hash *hash, char *func, int len, char *mod)
 	int exclude_mod = 0;
 	int found = 0;
 	int ret;
-	int clear_filter;
+	int clear_filter = 0;
 
 	if (func) {
 		func_g.type = filter_parse_regex(func, len, &func_g.search,

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ftrace: remove an unneeded NULL check Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-12 09:40 +0200
  [PATCH 2/2] ftrace: silence uninitialized variable warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-12 09:40 +0200
    Re: [PATCH 2/2] ftrace: silence uninitialized variable warning Steven Rostedt <rostedt@goodmis.org> - 2017-07-12 15:50 +0200

csiph-web