Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685452

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

Show all headers | View raw

>> -    unsigned long port_events_pending;
>> -    unsigned long phy_events_pending;
>> +    struct asd_sas_event   port_events[PORT_POOL_SIZE];
>> +    struct asd_sas_event   phy_events[PHY_POOL_SIZE];
>>
>>      int error;
> 
> Hi Yijing,
> 
> So now we are creating a static pool of events per PHY/port, instead of having 1 static work struct per event per PHY/port. So, for sure, this avoids the dynamic event issue of system memory exhaustion which we discussed in v1+v2 series. And it seems to possibly remove issue of losing SAS events.
> 
> But how did you determine the pool size for a PHY/port? It would seem to be 5 * #phy events or #port events (which is also 5, I figure by coincidence). How does this deal with flutter of >25 events?

There is no special meaning for the pool size, if flutter of > 25 events, notify sas events will return error, and the further step work is depending on LLDD drivers.
I hope libsas could do more work in this case, but now it seems a little difficult, this patch may be a interim fix, until we find a perfect solution.

Thanks!
Yijing.

> 
> Thanks,
> John
> 
> 
> .
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost Yijing Wang <wangyijing@huawei.com> - 2017-07-10 09:10 +0200
  Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost John Garry <john.garry@huawei.com> - 2017-07-11 17:40 +0200
    Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost wangyijing <wangyijing@huawei.com> - 2017-07-12 04:10 +0200
      Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost John Garry <john.garry@huawei.com> - 2017-07-12 10:20 +0200
        Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost wangyijing <wangyijing@huawei.com> - 2017-07-12 10:50 +0200
          Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost John Garry <john.garry@huawei.com> - 2017-07-12 12:20 +0200
            Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost wangyijing <wangyijing@huawei.com> - 2017-07-13 04:20 +0200
  Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas  event lost Hannes Reinecke <hare@suse.de> - 2017-07-14 08:50 +0200

csiph-web