Re: [PATCH v5 0/4] Make find_later_rq() choose a closer cpu in topology

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 0/4] Make find_later_rq() choose a closer cpu in topology
Date	Wed, 12 Jul 2017 04:50:02 +0200
Message-ID	<u2fSW-2cb-7@gated-at.bofh.it> (permalink)
References	<tK7qO-5fE-9@gated-at.bofh.it>
X-Original-To	peterz@infradead.org, mingo@kernel.org
X-Original-Senderip	156.147.1.125
X-Original-Mailfrom	byungchul.park@lge.com
X-Original-Senderip	10.177.222.33
X-Original-Mailfrom	byungchul.park@lge.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, juri.lelli@gmail.com, rostedt@goodmis.org, bristot@redhat.com, kernel-team@lge.com
X-Original-Date	Wed, 12 Jul 2017 11:44:41 +0900
X-Original-Message-ID	<20170712024441.GD20323@X58A-UD3R>
X-Original-References	<1495504859-10960-1-git-send-email-byungchul.park@lge.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1685473

Show key headers only | View raw

Could you check this patchset considering cpu topology on cpu selection?

On Tue, May 23, 2017 at 11:00:55AM +0900, Byungchul Park wrote:
> When cpudl_find() returns any among free_cpus, the cpu might not be
> closer than others, considering sched domain. For example:
> 
>    this_cpu: 15
>    free_cpus: 0, 1,..., 14 (== later_mask)
>    best_cpu: 0
> 
>    topology:
> 
>    0 --+
>        +--+
>    1 --+  |
>           +-- ... --+
>    2 --+  |         |
>        +--+         |
>    3 --+            |
> 
>    ...             ...
> 
>    12 --+           |
>         +--+        |
>    13 --+  |        |
>            +-- ... -+
>    14 --+  |
>         +--+
>    15 --+
> 
> In this case, it would be best to select 14 since it's a free cpu and
> closest to 15(this_cpu). However, currently the code select 0(best_cpu)
> even though that's just any among free_cpus. Fix it.
> 
> Change from v4
>    -. remove a patch that might cause huge lock contention
>       (by spin lock(&cpudl.lock) in a hot path of scheduler)
> 
> Change from v3
>    -. rename closest_cpu to best_cpu so that it align with rt
>    -. protect referring cpudl.elements with cpudl.lock
>    -. change return value of cpudl_find() to bool
> 
> Change from v2
>    -. add support for SD_PREFER_SIBLING
> 
> Change from v1
>    -. clean up the patch
> 
> Byungchul Park (4):
>   sched/deadline: Make find_later_rq() choose a closer cpu in topology
>   sched/deadline: Change return value of cpudl_find()
>   sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq()
>   sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()
> 
>  kernel/sched/cpudeadline.c | 26 ++++++++++++-------------
>  kernel/sched/deadline.c    | 48 +++++++++++++++++++++++++++++++---------------
>  kernel/sched/rt.c          | 17 ++++++++++++++++
>  3 files changed, 63 insertions(+), 28 deletions(-)
> 
> -- 
> 1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v5 0/4] Make find_later_rq() choose a closer cpu in  topology Byungchul Park <byungchul.park@lge.com> - 2017-07-12 04:50 +0200

csiph-web